Hi,

I found following problem.

The vTaskSuspendAll() suspends scheduler. It is called in many places in internal freeRtos files (e.g. queue.c, task.c, heap_4.c)

The problem is that if scheduler is suspended and the IRQ occur and inside this IRQ I call some API from freertos (e.g. xSemaphoreGiveFromISR or xQueueSendFromISR) then this call is triggering following assert:

            #if ( ( INCLUDE_xTaskGetSchedulerState == 1 ) || ( configUSE_TIMERS == 1 )

)

            {

                            configASSERT( !( ( xTaskGetSchedulerState() ==

taskSCHEDULER_SUSPENDED ) && ( xTicksToWait != 0 ) ) );

            }

File queue.c function xQueueGenericSend.

Simple test:

xSemaphoreHandle transmissionEnd;

transmissionEnd = xSemaphoreCreateBinary ();

UTILS_ASSERT (NULL != transmissionEnd);



vTaskSuspendAll();

xSemaphoreGiveFromISR (transmissionEnd, NULL); => this will trigger assert

I'm using v8.0.0 but I suspect that it is also in the newest version

Any ideas ?

Best regards

Łukasz Antczak

I just searched the source files (V8.2.1, not V8.0.0 admittedly) and can find four occurrences of:

configASSERT( !( ( xTaskGetSchedulerState() == taskSCHEDULER_SUSPENDED ) && ( xTicksToWait != 0 ) ) );

Two are in event_groups.c, so I have not looked at those. Two are in queue.c.

One of the two in queue.c is in xQueueGenericReceive(), and the other is in xQueueGenericSend() - but neither of those functions should get called in an ISR. xSemaphoreGiveFromISR() calls xQueueGiveFromISR() (or probably xQueueSendFromISR() in your version).

So I don't know why you would hit those asserts - other than to say it looks like a non-ISR safe function is being called from an ISR.

I would recommend stopping on the debugger when the assert has been hit and looking at the call stack to see the sequence of function calls that took you to the assert.

Regards.

Yes you are right. Thank you

From: Real Time Engineers ltd. [mailto:rtel@users.sf.net] Sent: Tuesday, April 7, 2015 9:54 PM To: [freertos:discussion] Subject: [freertos:discussion] vTaskSuspendAll() is causing assert in queue.c

I just searched the source files (V8.2.1, not V8.0.0 admittedly) and can find four occurrences of:

configASSERT( !( ( xTaskGetSchedulerState() == taskSCHEDULER_SUSPENDED ) && ( xTicksToWait != 0 ) ) );

Two are in event_groups.c, so I have not looked at those. Two are in queue.c.

One of the two in queue.c is in xQueueGenericReceive(), and the other is in xQueueGenericSend() - but neither of those functions should get called in an ISR. xSemaphoreGiveFromISR() calls xQueueGiveFromISR() (or probably xQueueSendFromISR() in your version).

So I don't know why you would hit those asserts - other than to say it looks like a non-ISR safe function is being called from an ISR.

I would recommend stopping on the debugger when the assert has been hit and looking at the call stack to see the sequence of function calls that took you to the assert.

Regards.

vTaskSuspendAll() is causing assert in queue.c https://sourceforge.net/p/freertos/discussion/382005/thread/78e52fdf/?limit=25#6164

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/freertos/discussion/382005/ https://sourceforge.net/p/freertos/discussion/382005

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/ https://sourceforge.net/auth/subscriptions